[ASM] Town Cleaner code

**Demonic722** · 07-12-2011

You could compare to immediate values (up to two digits in thumb):

Before:

Code:

ReviveFlowers:
ldrh r2,[r0,r1]
mov r3, #0x6F
cmp r2,r3
ble WaterFlowers
mov r3, #0x89
cmp r2,r3
bge WaterFlowers
sub r2,#0x6E

After:

Code:

ReviveFlowers:
ldrh r2,[r0,r1]
cmp r2, #0x6F
ble WaterFlowers
cmp r2, #0x89
bge WaterFlowers
sub r2, #0x6E

There's really no need to mov r3 by a byte and then compare. ^_^

Edit: You should load the map with a 32-bit load XD

**Maniac** · 07-12-2011

Code:

 mov r3, #0x6F  #Wilted Red Tulips start at 6E

I'll read the rest later.

**MisterNobody** · 07-13-2011

Thanks for your advices.

I've fixed the ASM source:

Edit: The AR codes in the first post are fixed (2 lines shorter).

**Demonic722** · 07-13-2011

It looks like the code posted was compiled with a different source XD. Not only because of the limitation of
only 1 "ldrh r0-r5, LabelHere" rule in thumb, but no where in the code 0xFFF1, or 0x1FFE is seen. o.o

**MisterNobody** · 07-13-2011

I've just changed 2-3 things because it doesn't want to compile with this source. But don't worry, the code seems to work, I've tested it myself. :P

**Demonic722** · 07-13-2011

Originally Posted by MisterNobody

I've just changed 2-3 things because it doesn't want to compile with this source. But don't worry, the code seems to work, I've tested it myself. :P

It doesn't compile because you have two "ldrh r0-r5, LabelHere" things XD :P

**MisterNobody** · 07-13-2011

Oh that's it ! Thank you I'm going to fix the source again. xD

Thread: [ASM] Town Cleaner code

Thread Tools

Display

Hybrid View

The Following User Says Thank You to Demonic722 For This Useful Post:

The Following User Says Thank You to Maniac For This Useful Post:

The Following User Says Thank You to Demonic722 For This Useful Post:

Posting Permissions