My first attempts at ASM

So uh yeah. First I tried messing with real-time world edit, but I figured that's too hard for a noob, so I tried messing with text to item. I decided to try make a "text to appearance" code. It works but not correctly. Uh here is what I got (I used an activator, but I'll just post the main code here)

Code:

---

removed

---

It seems to work randomly if I do it then hold the activator down when I go in or out of a building. I know I probably did something stupid, but if someone would help me I'd appreciate it :)

I'll look at it later for ya..

Thanks :p I know I at least got the right address for the appearance.

Alright, I noted it but I really cant say much else until I knwoo which address is which... Fyi I changed some things to my liking.. it still does the same thing.

Code:

---

ldr r1, Addy1 @Load Addy1 into r1
mov r5,#0x0 @mov 0x0 into r5
mov r0,#0x8 @mov 0x8 into r0
mov r2,#0xF @mov 0xF into r2
loop:
ldrb r3,[r1] @load byte from r1 into r3
add r1,#0x1 @add 0x1 into r1
cmp r3,#0x3A @compare r3 to 0x3A
blt number @if less less than go to number
add r3,#0x9 @Otherwise, add 0x9
number:
and r3,r2 @and r3,r2
lsl r3,r0 @logical shift left, multiplies by two for every shift
add r5,r3 @add r3 to r5 (why bother with this...?)
sub r0,#0x4 @subtract 0x4 from r0
bpl loop @branch if plus go to loop

ldr r2, Addy2 @load Addy2 into r2
strb r5,[r2] @Store byte of r5 into r2
bx lr
 
Addy1:
.long 0x022AF136 @what address is this...?
Addy2:
.long 0x021D9018 @same as comment above...

---

022af136 Is the address of the chat thing (I think)
021d9018 is your appearance (I got it from animal map in 32-bit mode)
I edited it a little bit and got it to correctly change my hairstyle and eyes, but not my tan or hair color. Here is my new source and code:

Code:

---

removed

---

Basically if I type 2 digits, it correctly changes my hair and eyes, but if I type any more than 2 it doesn't do anything else.
Edit: Actually, it still doesn't do it right, but it at least edits my hair style and eyes somewhat.

thats because your only running through the loop once? Just looking at a glance..

Code:

---

mov r0,#0x2
...
sub r0,#0x4
bpl loop

---

Uh..-asks noobish question- what do I put to run through more than once? :D
I knew I had to do more than 1 loop but I couldn't figure out how to do it
And it still probably won't work though

For starters shouldn't it be loading and storing a half word and not just a byte? Since I'm pretty sure it goes like.. 121D9018 0000xxxx

I used the text to item source though, and aren't item codes the same way? I'll try seeing what I did wrong

Oh yeah... forgot about that part its a bit different thatn virus's tti but w\e I'll look into it a bit more.. I'm a bit rusty in ASM atm having not used it in awhile..

I used the text to item source from RTWE, but Virus said it should work the same way (someone else was using it too)

yeah the one in RTWE was written for it to work in THUMB, virus's TTI only works for ARM. Anyhow I will look over it.

I took your advice and made it store/load a halfword. Now it edits my hairstyle/hair color and eyes, but it still won't edit my tan. Also it still doesn't do it correctly. Edit: I probably forgot something, but I changed the source to this

Code:

---

removed

---

Your load should be a loading a byte, the store shoulde be strh, or storing a halfword. oh, and have the loop execute 4 times.

I'll try that

Alright, tell me how it works..

Now when I press the activator, it makes the sky look awesome!! (it turns purple and the clouds zoom around :D) but it doesn't change my appearance.
I know how to store/load stuff but the reference sheet doesn't say anything about loops (so I don't know if I did it right or not)

Let me see the source?

Code:

---

removed

---

I know I probably shouldn't have put b and h for every single one, but I just wanted to see what happened

Try this...

Code:

---

ldr r1,=0x022AF136
mov r5,#0x0
mov r0,#0x10
mov r2,#0xF
loop:
ldrb r3,[r1]
add r1,#0x1
cmp r3,#0x3A
blt number
add r3,#0x9
number:
and r3,r2
lsl r3,r0
add r5,r3
sub r0,#0x4
bpl loop
 
ldr r2,=0x021D9018
strh r5,[r2]
bx lr

---

Still does the same thing.

Then make sure the address is right...

I meant it still randomly changes my appearance but never my tan, so the address must be right if it's changing my appearance.

I'm also working on making a real-time house editor, which is hard to convert from real-time world edit (especially for a noob like me) but I got it to work in the top left corner. (this would be a great code for people that accidentally dropped a seed in their house or something)

You'll never manage to edit it from RTWE without RTWE's source which is not public ;)

RTWE's source is in the amateur coding section :) it's on the 2nd page, on the last page of "coordinates to world map location"
and funny thing is, you have the last post there XD

I don't think thats the final version but if it is my mistake :D

It is the final version because when I put it in ASM to ARDS, it comes out exactly the same as the real-time world edit code in the releases section

Fair does, then it shouldn't be too hard lol do you understand the logics?

Uh, kinda...like 33%
I understand what most of it does but I don't really understand how I'm supposed to change it correctly. I know the correct addresses though :D If you'd be willing to help me somehow, you can PM me or email me

do you have msn or somthing of that irk?

[email protected]
I almost forgot it because I haven't used it in so long o.o

Quote:

---

I meant it still randomly changes my appearance but never my tan, so the address must be right if it's changing my appearance.

---

Yes.. the address could be correct for those 3 things, but seeing as the value that changes your tan is infront of the others it could be one byte too far. :P

As for the RTWE I understand all of it and in my free time I'll adjust it to work in the house if I feel like it... In order to adjust you have to know where the coordinates are on the map..

area51 is helping me with it, but im such a noob that im having trouble even with his help

Since when does AH know anything about ASM or the RTWE source? I'd stick to help from Maniac or Virus.

Well, he said he's helping me, but mostly making me find out myself (which is hard because some of the terms are impossible to find by myself, even in that 800 page asm manual thing) but he obviously knows a lot more about it than me

I acutally never read the 800 page thing... and yeah.. no offence to AH but hwat he knows is somewhat limited.

In my opinion, that quick reference thing has more information than that 800 page guide (at least it has more useful information)

Yeah.. that my opinion too actually lol...

I told him I didn't know much about it!