[ASM] Town Cleaner code

Printable View

07-12-2011
MisterNobody

[ASM] Town Cleaner code

I post my code here since I think it has been already made (nevertheless seperated in differents codes). :D

EU Version:

Code:

94000130 FFFC0000 023FF090 012FFF11 E0000000 00000046 E28F2001 E12FFF12 490E480D 2A6D5A42 2A89DD02 3A6EDA00 DA002A1B 21FF5242 31F10209 DD022A1E DA002A25 2A1B5243 5243D100 D1002A89 39025243 4770D5E6 021E6D4C 00001FFE 023FF090 E3520003 D2000000 00000000

US Version:

Code:

94000130 FFFC0000 023FF090 012FFF11 E0000000 00000046 E28F2001 E12FFF12 490E480D 2A6D5A42 2A89DD02 3A6EDA00 DA002A1B 21FF5242 31F10209 DD022A1E DA002A25 2A1B5243 5243D100 D1002A89 39025243 4770D5E6 021E3124 00001FFE 023FF090 E3520003 D2000000 00000000

US 1.1 Version:

Code:

94000130 FFFC0000 023FF090 012FFF11 E0000000 00000046 E28F2001 E12FFF12 490E480D 2A6D5A42 2A89DD02 3A6EDA00 DA002A1B 21FF5242 31F10209 DD022A1E DA002A25 2A1B5243 5243D100 D1002A89 39025243 4770D5E6 021E36A4 00001FFE 023FF090 E3520003 D2000000 00000000

ASM Source:

Code:

@Thumb mode add r2,pc,#1 bx r2 .thumb ldrh r0,Map ldrh r1,MapOffset ReviveFlowers: ldrh r2,[r0,r1] mov r3, #0x6F cmp r2,r3 ble WaterFlowers mov r3, #0x89 cmp r2,r3 bge WaterFlowers sub r2,#0x6E WaterFlowers: mov r3, #0x1B cmp r2, r3 bge RemoveWeeds strh r2, [r0,r1] RemoveWeeds: mov r3, #0x1E ldrh r5,Nothing cmp r2,r3 ble RemoveRafflesia mov r3, #0x25 cmp r2,r3 bge RemoveRafflesia strh r5, [r0,r1] RemoveRafflesia: mov r3, #0x1B cmp r2, r3 bne RemoveRafflesia2 strh r5, [r0,r1] RemoveRafflesia2: mov r3, #0x89 bne End strh r5, [r0,r1] End: sub r1,#2 bpl ReviveFlowers bx lr .arm Map: .long 0x21E6D4C MapOffset: .short 0x1FFE Nothing: .short 0xFFF1

Activator: A+B

Features:
- Revive all flowers
- Water all flowers
- Remove all weeds
- Remove Rafflesias

Thanks to Demonic. :p
07-12-2011
Demonic722

You could compare to immediate values (up to two digits in thumb):

Before:

Code:

ReviveFlowers: ldrh r2,[r0,r1] mov r3, #0x6F cmp r2,r3 ble WaterFlowers mov r3, #0x89 cmp r2,r3 bge WaterFlowers sub r2,#0x6E

After:

Code:

ReviveFlowers: ldrh r2,[r0,r1] cmp r2, #0x6F ble WaterFlowers cmp r2, #0x89 bge WaterFlowers sub r2, #0x6E

There's really no need to mov r3 by a byte and then compare. ^_^

Edit: You should load the map with a 32-bit load XD

Original:

Code:

ldrh r0,Map ldrh r1,MapOffset

Modified:

Code:

ldr r0,Map ldrh r1,MapOffset
07-12-2011
Maniac

Code:

mov r3, #0x6F #Wilted Red Tulips start at 6E

I'll read the rest later.
07-13-2011
MisterNobody

Thanks for your advices. :)

I've fixed the ASM source:

Code:

@Thumb mode add r2,pc,#1 bx r2 .thumb ldr r0,Map ldrh r1,MapOffset ReviveFlowers: ldrh r2,[r0,r1] cmp r2, #0x6D ble WaterFlowers cmp r2,#0x89 bge WaterFlowers sub r2,#0x6E WaterFlowers: cmp r2, #0x1B bge RemoveWeeds strh r2, [r0,r1] RemoveWeeds: mov r1, #0xFF lsl r1, #8 add r1, #0xF1 cmp r2,#0x1E ble RemoveRafflesia cmp r2,#0x25 bge RemoveRafflesia strh r3, [r0,r1] RemoveRafflesia: cmp r2, #0x1B bne RemoveRafflesia2 strh r3, [r0,r1] RemoveRafflesia2: cmp r2, #0x89 bne End strh r3, [r0,r1] End: sub r1,#2 bpl ReviveFlowers bx lr .arm Map: .long 0x21E6D4C MapOffset: .short 0x1FFE

Edit: The AR codes in the first post are fixed (2 lines shorter).
07-13-2011
Demonic722

It looks like the code posted was compiled with a different source XD. Not only because of the limitation of
only 1 "ldrh r0-r5, LabelHere" rule in thumb, but no where in the code 0xFFF1, or 0x1FFE is seen. o.o
07-13-2011
MisterNobody

I've just changed 2-3 things because it doesn't want to compile with this source. But don't worry, the code seems to work, I've tested it myself. :P
07-13-2011
Demonic722

Quote:

Originally Posted by MisterNobody

I've just changed 2-3 things because it doesn't want to compile with this source. But don't worry, the code seems to work, I've tested it myself. :P

It doesn't compile because you have two "ldrh r0-r5, LabelHere" things XD :P
07-13-2011
MisterNobody

Oh that's it ! Thank you I'm going to fix the source again. xD
07-13-2011
Demonic722

I made a remove all weeds, and rafflesia code today (In ASM) ^_^
Look at what I did to get FFF1, maybe you could add that to your new source:

Code:

@Branch To Thumb add r0,pc,#1 bx r0 .thumb @Fetch 0xfff1 ldr r0, Map ldrh r1, MapOffset lsl r2, r1, #3 add r2, #1 Loop: ldrh r3,[r0,r1] cmp r3, #0x1B beq RemoveWeed blt NoWeed cmp r3, #0x1F blt NoWeed cmp r3, #0x24 ble RemoveWeed bgt NoWeed b NoWeed RemoveWeed: strh r2,[r0,r1] NoWeed: sub r1, #2 bpl Loop bx lr .arm Map: .long 0x021E3124 MapOffset: .short 0x1FFE