ASM Please Check THis

[siestacat]

Hey Guys.


Made an ARDS Code for ACWW that You hold a button to advance time however long you like and hold another button to subtract from the time however long you like. Just wanted it to be checked for errors and such.


Finished Code Hold Left + L to go back in time however long and Right + R to go Forward in Time However Long

94000130 FEEF0000
023FF090 012FFF11
E0000000 00000018
E59F000C E5901000
E2811002 E5801000
E12FFF1E 021ECD84
023FF090 E3520003
D2000000 00000000
94000130 FDDF0000
023FF090 012FFF11
E0000000 00000018
E59F000C E5901000
E2411002 E5801000
E12FFF1E 021ECD84
023FF090 E3520003
D2000000 00000000

I think It'll Work. I'll Post meh ASM Source

I added a regular activator here.

ldr r0,TimeAddress
ldr r1,[r0]
add r1,#2
str r1,[r0]
bx lr

TimeAddress:
.long 0x21ecd84

Regular Terminator Here

Regular Activator Here

ldr r0,TimeAddress
ldr r1,[r0]
sub r1,#2
str r1,[r0]
bx lr

TimeAddress:
.long 0x21ecd84

Regular Terminator

Look Good?

[Fatboy12345236]

If it works then Also ask DB how to use @thumb to make your codes shorter I'm not learning ASM but I know it helps.

[siestacat]

Yeah I know thumb is more efficiant in some ways, but it also has some limitations such as you cannot use three digits when using arithmatic whereas in ARM 9 (7?) you can.

[dragonboy269]

Yeah I know thumb is more efficiant in some ways, but it also has some limitations such as you cannot use three digits when using arithmatic whereas in ARM 9 (7?) you can.

Oh and I need to teach you how to make that into just one routine, instead of two separate ones

By the way I've never had any problems with thumb, other than the fact that you only have 6 general purpose registers that you can use (which sometimes is barely enough, and sometimes isn't enough)

[siestacat]

K so you can put that into one routine?

[dragonboy269]

K so you can put that into one routine?

@Convert to thumb
add r2,pc,#1            
bx r2
.thumb

ldr r3,TimeAddress
ldr r4,[r3]

ldr r0,IOKeys
ldrh r0,[r0]
mov r1,#0x11
lsl r1,#4

CheckForward:
tst r0,r1
beq Forward
add r1,r1

tst r0,r1
bne Exit
sub r4,#4
Forward:
add r4,#2
str r4,[r3]
Exit:bx lr



.arm
IOKeys:
.long 0x4000130
TimeAddress:
.long 0x21ECD84

023FF090 012FFF11
E0000000 00000030
E28F2001 E12FFF12
681C4B08 88004806
01092111 D0034208
42081849 3C04D102
601C3402 00004770
04000130 021ECD84
023FF090 E3520003

same exact thing as you put, except in one routine. Try it (no need to add activator lines or anything)

sorry if there are errors, I'm half asleep

[siestacat]

Can it be done In standard ASM? I don't know Thumb ASM yet...

[dragonboy269]

Can it be done In standard ASM? I don't know Thumb ASM yet...

Uh,

ldr r3,TimeAddress
ldr r4,[r3]

ldr r0,IOKeys
ldrh r0,[r0]
mov r1,#0x11
lsl r1,#4

CheckForward:
tst r0,r1
beq Forward
add r1,r1

tst r0,r1
bne Exit
sub r4,#4
Forward:
add r4,#2
str r4,[r3]
Exit:bx lr


IOKeys:
.long 0x4000130
TimeAddress:
.long 0x21ECD84

023FF090 012FFF11
E0000000 00000044
E59F3038 E5934000
E59F002C E1D000B0
E3A01011 E1A01201
E1100001 0A000003
E0811001 E1100001
1A000002 E2444004
E2844002 E5834000
E12FFF1E 04000130
021ECD84 00000000
023FF090 E3520003

Notice what I did?

[siestacat]

Just took away the Convert to Thumb? lol

[dragonboy269]

Just took away the Convert to Thumb? lol

Yup
Thumb isn't very different from standard, except some things are limited
Just try making a regular ASM code then add the convert part and the .arm at the end

if it gives you problems, look closely at the error output and do what it says, pretty soon you'll know what you can and can't do in thumb (that's how i learned)